Fixed double-writes. #874
Merged
Fixed double-writes. #874
+44
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexLoyko
requested review from
VachaShah,
dblock,
harshavamsi,
axeoman,
Shephalimittal,
saimedhi and
florianvazelle
as code owners
AlexLoyko
force-pushed
the
fixed_double_writes
branch
from
60005e5 to
6534181
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #874 +/- ##
==========================================
+ Coverage 71.95% 73.45% +1.50%
==========================================
Files 91 77 -14
Lines 8001 5658 -2343
==========================================
- Hits 5757 4156 -1601
+ Misses 2244 1502 -742 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Alex Loyko <[email protected]>
AlexLoyko
force-pushed
the
fixed_double_writes
branch
from
6d6f198 to
0edf227
Compare
Signed-off-by: Alex Loyko <[email protected]>
Signed-off-by: Alex Loyko <[email protected]>
dblock
previously approved these changes
Dec 20, 2024
CHANGELOG.md
Outdated
| @@ -6,8 +6,10 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) | |||
| - Added option to pass custom headers to 'AWSV4SignerAsyncAuth' ([863](https://github.com/opensearch-project/opensearch-py/pull/863)) | |||
| - Added sync and async sample that uses `search_after` parameter ([859](https://github.com/opensearch-project/opensearch-py/pull/859)) | |||
| ### Updated APIs | |||
| - Updated opensearch-py APIs to reflect [opensearch-api-specification@a2afe56](https://github.com/opensearch-project/opensearch-api-specification/commit/a2afe567254c42aee70b74a8d7d7228c982b56db) | |||
There was a problem hiding this comment.
was confused because it auto-popped somehow
| @@ -236,7 +236,7 @@ async def test_nowarn_when_test_uses_https_if_verify_certs_is_off(self) -> None: | |||
| assert ( | |||
| str(w[0].message) == "enable_cleanup_closed ignored because " | |||
| "https://github.com/python/cpython/pull/118960 is fixed in " | |||
| "Python version sys.version_info(major=3, minor=12, micro=7, releaselevel='final', serial=0)" | |||
| "Python version sys.version_info(major=3, minor=12, micro=8, releaselevel='final', serial=0)" | |||
There was a problem hiding this comment.
This fine, but I'd prefer we fixed it once and for all by checking that the string contains https://github.com/python/cpython/pull/118960 and none of the other stuff.
Signed-off-by: Alex Loyko <[email protected]>
AlexLoyko
force-pushed
the
fixed_double_writes
branch
from
6559c6b to
06eea03
Compare
dblock
approved these changes
Dec 20, 2024
|
@AlexLoyko not sure why, but CI on main failed (and passed here) Can you please check https://github.com/opensearch-project/opensearch-py/actions/runs/12437036439/job/34726093595? PR fixes. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues Resolved
None, self-research
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.